[AxisBasedChart] Label drawing and NullOrEmpty label

microcharts-dotnet / Microcharts

Create cross-platform (Xamarin, Windows, ...) simple charts.

MIT License

2.02k stars 361 forks source link

[AxisBasedChart] Label drawing and NullOrEmpty label #237

Closed Seuleuzeuh closed 3 years ago

Seuleuzeuh commented 3 years ago

Changes :

Fix Null/Empty label drawing => Crash if Label is Null
Fix Series generation without label => Bad series/simple item generation when label is not fully filled and unique
Add sample for BarChart without Label => For issue testing

Fix issue :

Seuleuzeuh commented 3 years ago

@eman1986 any chance that will be merge soon ? I'm working an align Value label positioning (TopOfChart, TopOfElement -bar, point, ...-, OverElement) and the merge part on main block me to made a good PR.

eman1986 commented 3 years ago

Sorry about that, I thought I merged this already. Looks good.

microcharts-dotnet / Microcharts

[AxisBasedChart] Label drawing and NullOrEmpty label #237

137