microcharts-dotnet / Microcharts

Create cross-platform (Xamarin, Windows, ...) simple charts.
MIT License
2.03k stars 360 forks source link

Including a valueLabelOption alignment [Feature] #253

Closed Akinpellumie closed 3 years ago

Akinpellumie commented 3 years ago

Is your feature request related to a problem? Please describe. This nugget has been of great use and its getting more better day by day. However, I would like to make a request for a feature to be added to the future release. For developers that wants to display cash flow data with amount value aligned to the left including a shortname suffix, implementing this has been a lot of headache has the alignment for the value option is set to topOf Element as default.

Describe the solution you'd like So, my suggestion is if we can have more options to edit a barchart for instance with the captionalignment (valueLabelOption) feature that takes three options either: "LeftSideOfElement", "TopOfElement", "RightSideOfElement".

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Take a look at this sample image of a barchart with left aligned valueoption here: https://pnp.github.io/sp-dev-fx-controls-react/assets/BarChart.png

Seuleuzeuh commented 3 years ago

Hi @layioye, in the example image they are no data displayed for Bar element.

If i properly understand, you want a way to choose the HorizontalAlignment of the value label. So rather than adding other ValueLabelOption, i prefer adding an ValueLabelHorizontalAlignement property with default value of Center (to not break the existing apps) and can be changed to Left or Right.

This can be meet your behavior ?

Akinpellumie commented 3 years ago

Hi Morgan, Since the ValueLabelOption is the one set at the top of the bar, then adding ValueLabelHorizontalAlignment with an option to set it to either LEFT or RIGHT would be a greet deal. However, will there be a provision to hide/show the value at the top of the bar once I set my label alignment to the left or right? That would make it a great deal.

See the attached image below

On Tue, 13 Apr 2021, 3:36 pm Morgan SOULLEZ, @.***> wrote:

Hi @layioye https://github.com/layioye, in the example image they are no data displayed for Bar element.

If i properly understand, you want a way to choose the HorizontalAlignment of the value label. So rather than adding other ValueLabelOption, i prefer adding an ValueLabelHorizontalAlignement property with default value of Center (to not break the existing apps) and can be changed to Left or Right.

This can be meet your behavior ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dotnet-ad/Microcharts/issues/253#issuecomment-818787405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5J3YKHVY6LYVFDJXNYKC3TIRJH5ANCNFSM42NWM4RQ .

Seuleuzeuh commented 3 years ago

Based on the attached image, i think i don't understand your need. You want an Y axis with value data ?

Akinpellumie commented 3 years ago

Yes, that is correct.

On Thu, 22 Apr 2021, 9:16 am Morgan SOULLEZ, @.***> wrote:

Based on the attached image, i think i don't understand your need. You want an Y axis with value data ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dotnet-ad/Microcharts/issues/253#issuecomment-824639590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5J3YIZUNVOWVOI4BTQHILTJ7LMTANCNFSM42NWM4RQ .

Seuleuzeuh commented 3 years ago

So it's already available, on the master branch, with this properties on the every chart object that manage axis :

/// <summary>
 /// Show Y Axis Text?
/// </summary>
public bool ShowYAxisText { get; set; } = false;

/// <summary>
/// Show Y Axis Lines?
/// </summary>
public bool ShowYAxisLines { get; set; } = false;

/// <summary>
/// Y Axis Position
/// </summary>
public Position YAxisPosition { get; set; } = Position.Right;

This new feature will be available with the coming new release version (1.0), that will come shortly according to @eman1986. They are some more properties to customize the line and text visual. Look at this class for more info.

@eman1986 i think you can close this one.