microcharts-dotnet / Microcharts

Create cross-platform (Xamarin, Windows, ...) simple charts.
MIT License
2.03k stars 360 forks source link

Update GitHub Actions for publishing NuGet packages #328

Closed Eilon closed 1 year ago

Eilon commented 1 year ago

Hi @eman1986 , this PR updates the two GitHub Actions that are for building, packing, and publishing all the various NuGet packages in this repo to make them public on nuget.org.

It's based on a combination of the already-existing CI scripts in this repo, but adapting them to use the build introduced in an earlier PR.

Everything that was previously built & published is still there, plus all the various new packages that have been added over the past several months (.NET MAUI, Uno, and others).

I ran these as a test on my fork and they seemed to work just fine, except of course I couldn't actually publish the packages because only you have a valid nuget.org API key.

As part of the final publish step (that fails, because I don't have the key), I have the command list all the NUPKG files that it found, just to make sure it's the right list, and it looks correct:

Eilon commented 1 year ago

Alright, looks like this PR passes the PR checks here.

@eman1986 hopefully you have a chance to review & merge this, and then it's of course up to you to manually run the actions to push the updated packages to nuget.org. Please let me know if that's something you'd like any help with and I can work with you on the steps (I had to do a bunch of the same stuff on my own projects recently, so I'm quite familiar with all the ways to do it incorrectly 😁 ).

MartyIX commented 1 year ago

@eman1986 if you have a chance, please take a look. I would really love to try this.

AlleSchonWeg commented 1 year ago

Hi @Eilon , there is a discussion to port this library to Maui Toolkit: https://github.com/CommunityToolkit/Maui/discussions/232 Not sure if you know this. Perhaps it es a better way to port this to MAUI?! πŸ€·β€β™‚οΈ

Eilon commented 1 year ago

I have no horse in this race πŸ˜„ I'd love to see this library be published somewhere with .NET MAUI support (and all the other platforms it supports).

eman1986 commented 1 year ago

This is news to me lol. I'd prefer people just contribute to it here, rather than that solution as it looks like they'd totally change everything and also leave those using Xamarin or anything else out in the cold which defeats the purpose.

eman1986 commented 1 year ago

I will try to look at this this week, I greatly appreciate the hard work by everyone involved.

upswing1 commented 1 year ago

While we wait for the nuget packages to be published. What libraries do I need to install to have microcharts run under MAUI. Could someone tell me if I am missing something in my solution?

image

[!IMPORTANT] Don't forget to call UseMicrocharts() on MauiAppBuilder in the MauiProgram class.
In which dll is UseMicrocharts? is there a dll for microcharts.maui ?

Eilon commented 1 year ago

@upswing1 and anyone else interested: I published a build of the packages to a separate feed in case anyone wants to test them out. I published a sample app and short guide on it here: https://github.com/Eilon/MauiMicrochartsSample

upswing1 commented 1 year ago

I would like to express to you my thanks for doing that. πŸ™‚

upswing1 commented 1 year ago

Excellent news. Thank you very much for your work supporting this library.

Sent from my T-Mobile 5G Device Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: microspaze @.> Sent: Monday, June 12, 2023 1:51:31 AM To: microcharts-dotnet/Microcharts @.> Cc: upswing1 @.>; Mention @.> Subject: Re: [microcharts-dotnet/Microcharts] Update GitHub Actions for publishing NuGet packages (PR #328)

@microspaze approved this pull request.

Great!

β€” Reply to this email directly, view it on GitHubhttps://github.com/microcharts-dotnet/Microcharts/pull/328#pullrequestreview-1474079106, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIGJPKLVAL3MLLLQ4UASOSDXK2U6HANCNFSM6AAAAAAXOM3V7A. You are receiving this because you were mentioned.Message ID: @.***>

Eilon commented 1 year ago

@eman1986 I know it's been a while, but I was wondering if you could even optimistically merge this change and try to push packages? I would think worst case it either doesn't work at all, or it pushes bad packages, but then you could easily un-list the packages from nuget.org until we fix it. Thanks again!

microspaze commented 1 year ago

I have already upload a Microcharts.Maui lib to nuget: https://www.nuget.org/packages/Microcharts.Maui/

Pinox commented 1 year ago

Hi @eman1986 I assume you are very busy yourself with other work and I respect that but I think taking into account that many people are waiting for the official nuggets on this it would be kind of you to add @Eilon as an admin on this project so that he can get this repo live again. That is if Eilon agrees of coarse.

eman1986 commented 1 year ago

I'm really sorry for the delay on this guys, I've been slammed the last few weeks. I'm more than happy to add him as an admin if he so wishes.

Pinox commented 1 year ago

Thanks @eman1986. All good. Let me rather apologize for putting @Eilon on the spot. Eilon you have done alot of work on this would be great sir if you can get this for us over the finishing line. Will be much appreciated !!

Eilon commented 1 year ago

I'm happy to try to help with ownership/maintenance of the packages at least in the short term.

What I could propose it:

  1. @eman1986 adds me as owner to this repo/org
  2. @eman1986 adds https://www.nuget.org/profiles/Eilon as a co-owner of existing Microcharts packages on NuGet.org
  3. @microspaze transfer ownership of the uploaded MAUI package to https://www.nuget.org/profiles/Eilon on NuGet.org
  4. I would update the versions to 1.0.1 to mark them all as "released" and then publish an update for all packages to NuGet.org
  5. Profit 😁

If this is agreeable to folks, I'm happy to give this a try. (and even if #3 isn't possible we can always rename the package)

microspaze commented 1 year ago

I'm happy to try to help with ownership/maintenance of the packages at least in the short term.

What I could propose it:

  1. @eman1986 adds me as owner to this repo/org
  2. @eman1986 adds https://www.nuget.org/profiles/Eilon as a co-owner of existing Microcharts packages on NuGet.org
  3. @microspaze transfer ownership of the uploaded MAUI package to https://www.nuget.org/profiles/Eilon on NuGet.org
  4. I would update the versions to 1.0.1 to mark them all as "released" and then publish an update for all packages to NuGet.org
  5. Profit 😁

If this is agreeable to folks, I'm happy to give this a try. (and even if #3 isn't possible we can always rename the package)

Hi @Eilon, I have already add you to the ownners list of Microcharts.Maui package, and you need to approve it from nuget site. 1691304609116

Eilon commented 1 year ago

Hi @Eilon, I have already add you to the ownners list of Microcharts.Maui package, and you need to approve it from nuget site. 1691304609116

@microspaze thanks, I accepted it!

eman1986 commented 1 year ago

Sorry guys, I can make him an admin for the nuget packages. I can give him some more powers on the repo too if he's ok with that.

Eilon commented 1 year ago

Sorry guys, I can make him an admin for the nuget packages. I can give him some more powers on the repo too if he's ok with that.

Yes I'm fine with that. My main goal right now is to get updated packages pushed for everything.

eman1986 commented 1 year ago

you are now an owner of the microcharts packages @Eilon I appreciate all your help :)