search

microcipcip / cookie-universal

Universal cookie plugin, perfect for SSR
525 stars 39 forks source link

fix: added nodeCookie type for ICookie #135

Closed stephenjason89 closed 2 years ago

stephenjason89 commented 2 years ago

Updated type definitions

microcipcip commented 2 years ago

That's awesome! Do you know why all lines are being considered changed?

stephenjason89 commented 2 years ago

@microcipcip I'm not sure, but most probably because of the line breaks? I'm on mac. So might be because it's using LF and not CRLF?

On my other projects I use all LF line ending on my projects. I use .gitattributes file to enforce my line ending

* text=auto
image

here's the article https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/#a-simple-gitattributes-config

microcipcip commented 2 years ago

I see, I may have to convert all files to that.

stephenjason89 commented 2 years ago

@microcipcip maybe you can also use gitattributes to force convertion to CRLF to match the project? I just keep mine in auto though 😅

microcipcip commented 2 years ago

I'll do that as well, good point!