microcks / microcks-backstage-provider

A provider for Backstage.io allowing to synchronize API entities from Microcks to Backstage

https://microcks.io

Apache License 2.0

9 stars 6 forks source link

Hguerrer fix 16 dynamic plugin #18

Closed hguerrero closed 9 months ago

hguerrero commented 9 months ago

Description

Add changes to implement dynamic plugin for RH Developer Hub

Related issue(s)

16

lbroudoux commented 9 months ago

I think that the dist-dynamic/ folder should not be stored in Git and excluded. Maybe consider changing the .gitignore as well?

lbroudoux commented 9 months ago

Hey @hguerrero, there are 2 things to fix before merging:

Remove dist-dynamic/ folder from the PR and add it into the .gitignore of the repo as these are build output files
Sign the commit to pass the DCO check (this is a pre-requisites for all CNCF projects).

lbroudoux commented 9 months ago

I have an additional question: how do you release it? Should the dynamic stuff be included in regular build pushed on NPMJS.com or do we have to provide an alternative distribution?

lbroudoux commented 9 months ago

As agreed, we close this one waiting for a clean new one.