microcks / microcks-testcontainers-go

Go lib for Testcontainers that enables embedding Microcks into your unit tests with lightweight, throwaway instance thanks to containers.
https://microcks.io
Apache License 2.0
5 stars 3 forks source link

Allow Postman contract-testing support using ensemble design #16

Closed JulienBreux closed 5 months ago

JulienBreux commented 5 months ago

Description

This pull-request is designed to iso current developments for JS and Java.

Related issue(s)

lbroudoux commented 5 months ago

Just a suggestion: shouldn't we keep ensemble as a top-level concept just close to microns.go (and maybe rename it as microns-ensemble.go ?) and then move postman and async-minion containers in their own sub-packages ?

JulienBreux commented 5 months ago

Ok, no pb, I'll move to ensemble.go. And change some signatures.

JulienBreux commented 5 months ago

Just a suggestion: shouldn't we keep ensemble as a top-level concept just close to microns.go (and maybe rename it as microns-ensemble.go ?) and then move postman and async-minion containers in their own sub-packages ?

The main problem I see is options in the same package area (eg WithNetwork ... etc) What's real problem to use an import like import "microcks.io/testcontainers-go/ensemble vs import "microcks.io/testcontainers-go" in your opignon?

lbroudoux commented 5 months ago

No, no issue here. I was unaware of this constraint in Go and was much more thinking about having a similar approach between the different languages where possible. But I agree that we should also stick to language constraints, idioms and ways of doing things. I trust you for the Go Lang part 💪

lbroudoux commented 5 months ago

Thank you very much for the quick changes @JulienBreux! That's a great contribution!