Closed JulienBreux closed 5 months ago
Just a suggestion: shouldn't we keep ensemble
as a top-level concept just close to microns.go
(and maybe rename it as microns-ensemble.go
?) and then move postman
and async-minion
containers in their own sub-packages ?
Ok, no pb, I'll move to ensemble.go. And change some signatures.
Just a suggestion: shouldn't we keep
ensemble
as a top-level concept just close tomicrons.go
(and maybe rename it asmicrons-ensemble.go
?) and then movepostman
andasync-minion
containers in their own sub-packages ?
The main problem I see is options in the same package area (eg WithNetwork ... etc)
What's real problem to use an import like import "microcks.io/testcontainers-go/ensemble
vs import "microcks.io/testcontainers-go"
in your opignon?
No, no issue here. I was unaware of this constraint in Go and was much more thinking about having a similar approach between the different languages where possible. But I agree that we should also stick to language constraints, idioms and ways of doing things. I trust you for the Go Lang part 💪
Thank you very much for the quick changes @JulienBreux! That's a great contribution!
Description
This pull-request is designed to iso current developments for JS and Java.
Related issue(s)