microcks / microcks-testcontainers-java

Java lib for Testcontainers that enables embedding Microcks into your JUnit tests with lightweight, throwaway instance thanks to containers.
https://microcks.io
Apache License 2.0
22 stars 5 forks source link

Remove the methods for using fixed ports #15

Closed lbroudoux closed 1 year ago

lbroudoux commented 1 year ago

Reason/Context

Fixing ports is not recommended by Test containers as we're - by nature - evolving into volatile environments that should be dynamically configurable / re-configurable. All the ports exposed by a testcontainer should be dynamic with the ability to retrieve them using a dedicated method.

Description

The setHttpExposedPort(int httpPort) and setGrpcExposedPort(int grpcPort) methods where introduced for debugging purpose and specific needs of the Quarkus DevServices but are no longer needed as we now know how to use dynamic ports on Quarkus use-cases ;-)

They can be removed.

Implementation ideas

Remove both methods for fixing Http and Grpc ports.