search

microdotblog / microblog-react

MIT License
29 stars 3 forks source link

When editing post, don't allow swipe to dismiss on post modal #72

Closed vincentritter closed 8 months ago

vincentritter commented 8 months ago

Because we changed the behaviour of loading edits, which basically purges them when the editor closes, plus that we're usually normally "re-hydrating" the post as soon as we load up the editor, we need to disallow a swipe to dismiss.

This was brought up here: https://help.micro.blog/t/mb-app-bug-careless-scrolling-with-lose-edits/2207.

Please also update the above post on help once fixed.

manton commented 8 months ago

@vincentritter If you haven't started on this, I'm going to make this change. I'm looking at a couple other editing tweaks too.

manton commented 8 months ago

Putting my changes in branch fix/more-little-tweaks.

vincentritter commented 8 months ago

Just in case you haven't seen my comment @manton, please go ahead with this.

manton commented 8 months ago

I've made the change. I also decided to disable swipe to dismiss in all the text editing modals: edit post, new post, reply. Seems more consistent that way.

manton commented 8 months ago

Closing, this will be in 3.2.2.