search

microdotblog / microblog-react

MIT License
30 stars 3 forks source link

Fix crash in iOS Share Extension #76

Closed vincentritter closed 8 months ago

vincentritter commented 8 months ago

This fixes the issue with the crashing share extension. Reading the comments about "every second load crashes the app" is consistent to what we're seeing also — I thought it was a memory issue at first, but it was always the second time it loads up, after a successful load, that it crashes — all the time.

So this includes a fix, using: https://github.com/Expensify/react-native-share-menu/pull/271

I also added fixes from here: https://github.com/Expensify/react-native-share-menu/pull/295

I can confirm that the extension no longer crashes.

TODO: The Share extension is no longer working because we have commented it out in App.js — I can see why that was done, so will need to figure out how to bring it back — this is beyond this PR and will concentrate on Android in another release (which we're due to do).

vincentritter commented 8 months ago

Just for info @manton — once again I used bun but feel free to run it with yarn — because of the available patch, it would need to be applied running either bun install or yarn install — or yarn patch-package.

manton commented 8 months ago

Excellent! Merging in. I think the Android thing I commented out temporarily… Should be safe to uncomment.