microdotblog / microblog-react

MIT License
30 stars 3 forks source link

Micropub server config not refreshed when adding WordPress or compatible blog #95

Open paulrobertlloyd opened 1 month ago

paulrobertlloyd commented 1 month ago

When testing changes in different builds, I often find it to be the case that to check if something is fixed, I need to delete the app and reinstall it to see if that fix has been applied.

It seems as though when adding a WordPress or compatible blog, if that blog was added previously, the previous settings remain, and are not checked afresh.

vincentritter commented 1 month ago

Thanks for bringing this up. At the moment it won't recheck your endpoint when you load the app from "cold" (it'll only check for the Micro.blog token validity and log you out if something is amiss) — perhaps we should change that.

What would your suggestions be here, is there anything specific you'd like to see?

There should be a way to reset and start again, where you select the "Micro.blog hosted blog" option — however when I look over the code it actually just selects that option and makes it the default, without deleting the other one. I believe I've done that on purpose and recognise we should have an option to just delete the custom endpoint.

Please give me your thoughts on this though.

paulrobertlloyd commented 1 month ago

Given that a Micropub config can contain a number of items that may change often (categories, syndication targets etc…), it should be easier to fetch the current configuration from a Micropub server without needing to delete the app and reinstall it.

Perhaps this can be done whenever you click the cog icon on the post screen? Though I could imagine that slowing down the appearance of options on that screen. Maybe adding an option to refresh the config on the post options screen would be enough?

FWIW, Sparkles has such an option on its settings screen:

Screenshot of the settings screen in Sparkles.
vincentritter commented 1 month ago

I've been looking at this, see commit attached, and from what I can see we should be grabbing an up to date config when we boot from cold and also update categories and syndicate-to targets each time we load up the New Post screen.

I've added an extra check to update syndicate targets also when opening a screen if you're using a MicroPub endpoint. In addition to that, I have added an extra method to refresh the config for a XMLRPC/Wordpress based blog when we're loading the new post screen.

There is more I can do here (and need to test). I think adding an indicator on when the config was last checked would be a nice to have on the settings screen.

I need to do some testing on the Wordpress front — if you're using the XML endpoint it won't grab any syndicate-to data (as far as I am aware this doesn't come through anyway).

We're working on a 3.3.1 update at the moment, and the above commit will be there and hopefully it'll fetch what it should.

paulrobertlloyd commented 1 month ago

Lovely stuff, thanks @vincentritter! Looking forward to testing this change in an upcoming (TestFlight?) release.

vincentritter commented 1 month ago

I'll talk to @manton about this as TestFlight releases also need to be approved, which usually is slower than actually getting out a full release. However, we should have it available as a TestFlight as there are few other bugs I need to look at and get tested.

manton commented 1 month ago

I'm uploading a TestFlight build now. If anyone's not on the beta, here's a link: https://testflight.apple.com/join/lWxM21hn