search

microfleet / ioredis-lock

Node distributed locking using redis
MIT License
26 stars 8 forks source link

Does not work on Node 4.x #5

Closed aabrams closed 7 years ago

aabrams commented 8 years ago

Uses es6 syntax not available on 4.x

AVVS commented 8 years ago

yep, no longer supported. you can install earlier versions with support for it

aabrams commented 8 years ago

OK, using 2.x for now. thanks!

behrad commented 8 years ago

I'm also locked to 2.x cause of using node v4 Can you update to the latest ioredis for 2.x @AVVS ?

AVVS commented 8 years ago

yes, I'll make a separate branch for this

behrad commented 8 years ago

Great @AVVS waiting for this...

another issue is you are defining ioredis 1.x in peerDependencies! That's locking my module to use ioredis 2.x! Ain't it better to add it to optionalDependencies or simply dependencies?

Or even upgrade to ioredis 2.x version dependency.

bkw commented 7 years ago

node v4 support now has a PR in #8

AVVS commented 7 years ago

Fixed thanks to @bkw, version is published under @legacy tag in npm, do npm i ioredis-lock@legacy -S to get it, mentioned this on the master README and added an extra note regarding branch where it is developed