search

microformats / microformats-ruby

Ruby gem that parse HTML containing microformats/microformats2 and returns Ruby objects, a Ruby hash or a JSON hash
https://rubygems.org/gems/microformats
Creative Commons Zero v1.0 Universal
100 stars 29 forks source link

CI doesn't accurately test everything #101

Closed dissolve closed 1 year ago

dissolve commented 6 years ago

version 4.0.8 was able to be released and passed all CI tests, but it failed when testing on a different system as 'require "set"' was not in the code base... why do all tests pass despite this??

jgarber623 commented 6 years ago

Can you provide some extra system details? I just installed v4.0.8 on macOS 10.13.6 (gem install microformats -v 4.0.8) and was able to successfully use the CLI:

microformats https://sixtwothree.org

…without any errors.

dissolve commented 6 years ago

The error I got was an uninitialized constant on format_parser:10 (going of of memory). This was the line that first used Set::. This was fixed by adding require 'set'. I don't know why this worked on some machines and not on others however.

I will have to look in to it closer

On Mon, Aug 27, 2018, 9:38 PM Jason Garber notifications@github.com wrote:

Can you provide some extra system details? I just installed v4.0.8 on macOS 10.13.6 (gem install microformats -v 4.0.8) and was able to successfully use the CLI:

microformats https://sixtwothree.org

…without any errors.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microformats/microformats-ruby/issues/101#issuecomment-416422227, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbZ4XCteKTkRtWAQi9isC1su1YrCvCTks5uVJ7SgaJpZM4WOGeo .

jgarber623 commented 6 years ago

Okay, so after asking around, I think the problem breaks down to a misunderstanding on my part of the Ruby "core" vs. the "standard library."

Set is part of the standard library and would need to be included using require 'set' as you've done. Apologies on my part for having possibly introduced that problem.

That might be the resolution to this issue.

dissolve commented 6 years ago

Well it solved the issue, that's exactly what I did for 4.0.9. The real issue here is that the CI server and my dev server (ubuntu) automatically included the standard libraries, while my personal machine (gentoo) after deploy did not. The goal is for the CI environment to be more strict and not auto-include standard libs as obviously not all systems do that.

dissolve commented 1 year ago

i think this can be closed now?

jgarber623 commented 1 year ago

i think this can be closed now?

@dissolve Yep, closing!