search

microformats / tests

Microformats test suite
http://microformats.org/wiki/microformats2
Creative Commons Zero v1.0 Universal
64 stars 20 forks source link

Add new test for nested IDs #121

Closed jgarber623 closed 6 months ago

jgarber623 commented 3 years ago

This PR adds a new test for nested IDs as noted by @Zegnat in #120.

Zegnat commented 3 years ago

I wonder if there is something to win by also including a "negative" test?

  <div id="d" class="p-y"></div>

The d should not show up in the microformats output then.

Also wondering if we want to accept tests that make no sense content wise. Not even the microformats of this example make any sense, even if they are completely valid for testing the parser edge-cases. Not sure what our policy on that should be.

jgarber623 commented 3 years ago

I agree that real-world examples (or at least real-world adjacent) examples are more helpful. @Zegnat Want to update your example and I can update the test files?

jgarber623 commented 3 years ago

@Zegnat Wanted to follow up on this. Looking back at my comment above, do you want to update your example and I can update the test files? Or, is this PR in an acceptable place to merge?