Fix h-resume tests - Githubissues

cleverdevil commented 6 years ago

In these two h-resume tests:

tests/microformats-v2/h-resume/education.json
tests/microformats-v2/h-resume/work.json

... the education property contains a strange blend of h-card and h-event, which isn't documented in the spec, and seems incorrect. These should be fixed to be h-event with potential embedded h-card objects instead.

jgarber623 commented 5 years ago

So I just tried running the example markup in the following files…

tests/microformats-v2/h-resume/education.html
tests/microformats-v2/h-resume/work.html

…through the following Web-based parsers…

…and each one returned a result matching what's in the aforementioned JSON files.

Very strange. The h-resume/hresume examples are the only ones in the entire test suite where the type property has multiple values (h-card and h-event). There aren't very good examples on either of the pages (here and here) on the wiki, either.

🤔

gRegorLove commented 5 years ago

I think the h-card should be embedded as a property of the h-event, like:

<div class="h-resume">
<p class="p-education h-event">
    <span class="p-location h-card"><span class="p-name p-org">The Queen's College, Oxford University</span></span>, 
    <span class="p-description">BA Hons (I) Physics</span> 
    <time class="dt-start" datetime="1973-09">1973</time> –
    <time class="dt-end" datetime="1976-06">1976</time>
</p>
</div>

microformats / tests

Fix h-resume tests #83