search

microformats / tests

Microformats test suite
http://microformats.org/wiki/microformats2
Creative Commons Zero v1.0 Universal
64 stars 20 forks source link

Update self-closing p-* properties test results #92

Closed jgarber623 closed 6 years ago

jgarber623 commented 6 years ago

@dissolve reported this one in #75 based on issue #72 in the microformats/microformats-ruby repo. The relevant conclusion from that thread is:

Thanks to @domenic (i'm assuming since same name on IRC), it is generally understood that the concatination of the null set is the empty string. This would mean nokogiri is correct and the test suite is incorrect.

Accordingly, this change adds two empty strings to the honorific-suffix result array, resolving #75.

dissolve commented 6 years ago

the PHP, Ruby, and Python parser all agree on this result already. (i have not tested others yet)

jgarber623 commented 6 years ago

@dissolve For clarity's sake, your comment implies that the change in this PR would bring the test suite in line with the behavior of the PHP, Ruby, and Python parsers?

dissolve commented 6 years ago

Correct

On Mon, Aug 13, 2018, 9:18 PM Jason Garber notifications@github.com wrote:

@dissolve https://github.com/dissolve For clarity's sake, your comment implies that the change in this PR would bring the test suite in line with the behavior of the PHP, Ruby, and Python parsers?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microformats/tests/pull/92#issuecomment-412720312, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbZ4ViSYjzf5SeggjGlmqpT_OAw04vtks5uQiUxgaJpZM4VxZmB .

jgarber623 commented 6 years ago

@dissolve Excellent, thanks! Who has the appropriate access on this repo to merge and close this PR?