microg / GmsCore

Free implementation of Play Services
https://microg.org
Apache License 2.0
8.6k stars 1.72k forks source link

Hard-coded strings #2445

Open lucasmz-dev opened 4 months ago

lucasmz-dev commented 4 months ago

Describe the bug Ping interval is not translated. (PT-BR has a 100% translated rating)

To Reproduce Steps to reproduce the behavior:

  1. Go to Cloud Messaging
  2. Click on the 3 dots at the top right, Advanced
  3. Click on any of the network options
  4. See missing translation

Expected behavior These strings should be translated

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot_20240712-075313

System Android Version: 14 Custom ROM: CalyxOS 5.9.0

Additional context I suspect there are hard coded? Need to check

Vavun commented 4 months ago

I suspect there are hard coded?

true https://github.com/microg/GmsCore/blob/e53cd0630362dfe7bd76c1f3c0655d0a0d9208c6/play-services-core/src/main/res/values/arrays.xml#L45-L57

lucasmz-dev commented 3 months ago

I was supposed to send this yesterday, or earlier today, but I found another one and I don't think it's worth opening another issue.

Location > Click on app on recent access > Last reported location