search

microg / GmsCore

Free implementation of Play Services
https://microg.org
Apache License 2.0
8.67k stars 1.73k forks source link

Generate Creator class for com.google.firebase.dynamiclinks.internal.DynamicLinkData by adding respective annotation #2615

Closed derMart closed 5 days ago

derMart commented 1 week ago

Fixes #2596 After refactor via https://github.com/microg/GmsCore/commit/3ccb5f456e7ee05bd3e445567194707b5b02fe0a the @SafeParcelable.Class annotation is still missing in com.google.firebase.dynamiclinks.internal.DynamicLinkData. Also the safe-parcelable process needs to be added to the gradle build file. @mar-v-in When searching for "AbstractSafeParcelable" in the source tree I do see that there are more places where the annotation is missing. If you like, I might fix those with this PR too.

best

mar-v-in commented 1 week ago

This has also been submitted under #2519

ale5000-git commented 5 days ago

Since this is already included in #2519 and the PR is already merged it is time to close also this.

ale5000-git commented 5 days ago

@derMart Fell free to submit a new PR for the remaining issues, any contribution is appreciated.