microg / GmsCore

Free implementation of Play Services
https://microg.org
Apache License 2.0
8.73k stars 1.75k forks source link

In-app purchase support #309

Closed acsway878787 closed 8 months ago

acsway878787 commented 7 years ago

I installed Google Play store and microG service core. I found that In-app purchase sometimes worked and sometimes not. So is In-app purchase official support?

coxtor commented 5 years ago

@Nanolx Hi, I am coming from a clean install on lineage 16.0 Magisk + Nanodroid + Nanodroid Repository using your modified Play Store. All appears to work fine however, I can not download any of my purchased items, even though I can see them in my purchase history in the same app. Furthermore Applications using in app purchases do not recognize purchased in app purchases. However, if I attempt to purchase the item again, I get a toast message that I already own the item. This message does not unlock the items functionality though. The Logcat does not show any failures just many reauths. Any advise?

Nanolx commented 5 years ago

Did you grant fake package signature pemission? Does your device pass SafetyNet?

Am 18. April 2019 21:48:26 MESZ schrieb coxtor notifications@github.com:

@Nanolx Hi, I am coming from a clean install on lineage 16.0 Magisk + Nanodroid

  • Nanodroid Repository using your modified Play Store. All appears to work fine however, I can not download any of my purchased items, even though I can see them in my purchase history in the same app. Furthermore Applications using in app purchases do not recognize purchased in app purchases. However, if I attempt to purchase the item again, I get a toast message that I already own the item. This message does not unlock the items functionality though. The Logcat does not show any failures just many reauths. Any advise?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/microg/android_packages_apps_GmsCore/issues/309#issuecomment-484662756

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

coxtor commented 5 years ago

Wow - that was a simple fix. I enabled SafteyNet in the settings app as you suggested and it started to work. Thank you. At this point it might be worth mentioning that the options in the app which can be enabled are not quite clear and what their functions imply. Perhaps a label below the options would help other users? What would be the point of having only SafetyNet enabled or only the device registration or any other combination? I would love to contribute this information however I do not have the necessary knowledge.

Furthermore could you elaborate on the modification you made to the play store at some point if you have time? Is there more telephoning home going on, or is this removed also? How invasive and nosy is the modified play store with microg installed?

Nanolx commented 5 years ago

Yes, an ordinary user may want to simply enable all device registration, GCM and SafetyNet, but there are users who don't. The wiki could be improved, yes, I had in mind to spend some time improving it, though that's not going to be soon™.

The changes I made to the Play Store is only so that it uses signature spoofing and disabling most of it's update checks (to reduce battery drain to a minimum; else Play Store would endlessly try to update Play Services and itself, contributed by @Vavun), to ensure it's signature in-system is the same as microG's else security checks will not allow (in-)app-purchases if the don't match.

You can find the patch here, currently version 14.5.52: https://gitlab.com/Nanolx/NanoDroid/blob/master/doc/Phonesky.diff

MartinX3 commented 5 years ago

@Nanolx People like me who wants to use the Aurora Store are still excluded.

External workarounds doesn't seem to be valid fixes in my opinion.

Nanolx commented 5 years ago

Nobody will re-implement Google's license validation and purchase API. That would be a clear TOS violation, may even be considered illegal in some countries.

Am 17. September 2019 17:06:36 MESZ schrieb "Martin Dünkelmann" notifications@github.com:

@Nanolx People like me who wants to use the Aurora Store are still excluded.

External workarounds doesn't seem to be valid fixes in my opinion.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/microg/android_packages_apps_GmsCore/issues/309#issuecomment-532263475

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

MartinX3 commented 5 years ago

But your play store hack is a license violation either. So this issue can't ever get fixed (external).

That's sad, since that's the only issue for me to switch to microG forever.

Nanolx commented 5 years ago

But not replicating any API. All I do is giving PS fake signature permission, all functional code is unchanged, all APIs are official, including access to them.

So yes it's a TOS violation, but not as critical and potentially "piracy" (wtf is illegal duplication verbally linked to pirates??) allowing re-implentation of the license validation API.

Am 17. September 2019 18:15:07 MESZ schrieb "Martin Dünkelmann" notifications@github.com:

But your play store hack is a license violation either. So this issue can't ever get fixed (external).

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/microg/android_packages_apps_GmsCore/issues/309#issuecomment-532292153

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

MartinX3 commented 3 years ago

Sadly there was no update since 10 months from @Nanolx and accordingto a bug report, it won't work with LineageOS 18.1 (Android 11) :( So back to OpenGapps Pico :(

https://gitlab.com/Nanolx/microg-phonesky-iap-support

mar-v-in commented 8 months ago

Initial experimental support for in app billing (purchases and subscriptions) landed in master.

Vavun commented 8 months ago

Initial experimental support for in app billing (purchases and subscriptions) landed in master.

What about a new nightly for testing please?

Atemu commented 8 months ago

The commit for reference: https://github.com/microg/GmsCore/commit/d4d7713f8a045c7f08ed3ff659cd50a7878e326f

How does that work? Do you still need the Play Store installed to facilitate the purchase?

mar-v-in commented 8 months ago

You need latest version (0.3.1) of microG Services and microG Companion.