search

microg / GmsCore

Free implementation of Play Services
https://microg.org
Apache License 2.0
8.67k stars 1.73k forks source link

armeabi support #867

Open ale5000-git opened 5 years ago

ale5000-git commented 5 years ago

In this change:https://github.com/microg/android_packages_apps_GmsCore/commit/dfb1e7fbb7d6225353cd31b94558a2bce5a2f5a2

What happen if the phone doesn't support armeabi-v7a? Does the app still works without map?

mar-v-in commented 5 years ago

Mapbox seems to be incompatible with armeabi < v7a. I guess this will just crash on older ARMs or maybe can't even be installed.

Devices with that old ARM versions probably also lack proper GPU for 3d map rendering anyways.

ale5000-git commented 5 years ago

@mar-v-in: It would be nice if in this case it just use a dummy map to make the rest of the app working (the map may be a secondary part of the app in some cases).

Dummy map will be useful also after the map api separation when the map api is not installed.

voidstarstar commented 5 years ago

When the modular design is complete, armeabi < v7a devices should probably be able to just select a different map back end.

Related to #802.

(Edit: I wonder if a mocking library could somehow be abused to make creating default stubs easier.)

ale5000-git commented 5 years ago

@voidstarstar: Yes, but it must also cover the case of NO map backend installed for the principle of graceful degradation :)

mar-v-in commented 5 years ago

Yes, but no maps is still some implementation work to not cause crashes, for example the method to create a marker on the map must be implemented and return a dummy marker. It's planned but still requires work.