search

microg / IchnaeaNlpBackend

Backend for UnifiedNlp that uses Mozilla Location Service for geolocation.
119 stars 28 forks source link

Crashes when selected in UnifiedNlp settings #21

Closed rugk closed 8 years ago

rugk commented 8 years ago

ROM: CM-13.0-20160325-NIGHTLY-jfltexx

Using the XposedUnifiedNlp module and UnifiedNlp (v1.6.2-dirty) I can successfully access and configure the settings of the Mozilla Location services backend, but when I go (back) to the UnifiedNlp settings, activate this backend and click "ok" the default Android crash message is shown.

mar-v-in commented 8 years ago

Enable location permission in settings->apps or use v1.3.0 and disable/re-enable the backend.

rugk commented 8 years ago

Indeed this worked. Why is not this permission requested when starting the app/accessing the settings as it should in Android 6? Or why is not there at least a note in the settings that one should do this if it does not work? (Unexpected crashes are very bad UX :smile:) Alternatively/Additionally the app should also show an error message if it has no permissions instead of crashing... if this is possible.

mar-v-in commented 8 years ago

Support for Android 6 landed in UnifiedNlp v1.6.0 and Mozilla backend v1.3.0. If you use v1.3.0 it should ask for permission once activated and should not crash when it is not granted.

rugk commented 8 years ago

I am using the newest builds from FDroid. It seems for the mozilla backend v1.3 is not yet there.

rugk commented 8 years ago

BTW if all things I asked before are already solved, you may of course close this issue.