search

microg / android_external_MicroGUiTools

UI helpers used in GmsCore and UnifiedNlp
Apache License 2.0
33 stars 27 forks source link

Try to fix Issue #267 #9

Open acsway878787 opened 7 years ago

ale5000-git commented 7 years ago

Since it isn't clear, the correct ref is this: https://github.com/microg/android_packages_apps_GmsCore/issues/267

mar-v-in commented 7 years ago

@acsway878787 did you try to compile it, did it work?

acsway878787 commented 7 years ago

@mar-v-in Sorry,I didn't. I want to compile myself but I'm lack of knowledge in Linux. I tried to build in Android Studio and it showed error, then I used apktool to make changes but couldn't compile. Could you give me a hand on this?

acsway878787 commented 7 years ago

@mar-v-in I'm sorry that I didn't test before create this pull request. What's bad, I didn't work. I'll try my best to find out.

emv412 commented 6 years ago

I can confirm this solves this issue, compiled it and installed on Asus Fonepad 7 (crashed earlier). It seems Asus devices have this problem.

You also need to remove android:theme="@style/TextAppearance.AppCompat.Title.Inverse"/> from android_external_MicroGUiTools/microg-ui-tools/src/main/res/layout/app_bar.xml to work as intended.

ale5000-git commented 6 years ago

@emv412: Could you please open a pull request?

acsway878787 commented 6 years ago

@emv412 Glad to hear someone find the solution. I didn't pay attention on this after I updated my PFS to MM.Could you explain why this issue will occur? By the way, I think people who face this problem should build microg on their own with these changes, because merge this PR will change the style of Text somewhere universally, in my opinion.