search

microlinkhq / async-ratelimiter

Rate limit made simple, easy, async.
MIT License
320 stars 23 forks source link

node-redis support #22

Closed bard closed 5 years ago

bard commented 5 years ago

Following up from https://github.com/microlinkhq/async-ratelimiter/issues/19#issuecomment-484870327, async-ratelimiter does not work with node-redis, only ioredis. Probable culprit: https://github.com/microlinkhq/async-ratelimiter/blob/master/src/index.js#L42

Kikobeats commented 5 years ago

I'm not interested into support node-redis since ioredis have all the features necessaries and the project is well maintained 🙂

bard commented 5 years ago

That's fair enough.

This module is mentioned as a "Promise version" of node-ratelimiter on node-ratelimiter page, so people moving from there will come here expecting the same features minus callbacks plus promises, like I did. It might make sense to be explicit about redis client support.