microlinkhq / metascraper

Get unified metadata from websites using Open Graph, Microdata, RDFa, Twitter Cards, JSON-LD, HTML, and more.
https://metascraper.js.org
MIT License
2.35k stars 168 forks source link

Missing 'logo' in Metadata interface when using metascraper-logo plugin #657

Closed quentingrchr closed 12 months ago

quentingrchr commented 1 year ago

Prerequisites

The 'logo' property in Metadata interface is missing when using metascraper-logo plugin

When I use metascraper with Typescript with those plugins :

The Metadata interface doesn't include the new properties added by the metascraper-logo and metascraper-logo-favicon plugins

Steps to reproduce

Go to the reproduction link Line 43 the logo property doesn't exist

Expected behaviour

Metadata Interface should reflect all the property added by the plugins (in this example 'logo')

Actual behaviour

Metadata doesn't have the property added by the metascraper-logo and metascraper-logo-faviconplugins

Kikobeats commented 1 year ago

Can you make a PR? 🙏