Color detection is broken for logos

microlinkhq / open

4 stars 2 forks source link

Color detection is broken for logos #44

Closed spiffytech closed 2 years ago

spiffytech commented 2 years ago

Bug Report

Current Behavior

Maybe 2-3 days ago, Meta API color detection for logos stopped working. Every site I've checked either has no color properties returned, or has them returned as null.

Without the logo color, my app has to fall back to the detected color from the OpenGraph image, which usually makes no sense since they don't include the site's brand colors.

Expected behavior/code

Fetching metadata with palette enabled should return logo colors

Additional context/Screenshots

I filed #42 and #43 before realizing this issue appears to be universal, rather than plaguing specific sites, and that it's specifically about logo colors and not OG image colors.

Kikobeats commented 2 years ago

Hello, and thanks for reporting.

I'm working in to fix this asap 🙂

Kikobeats commented 2 years ago

@spiffytech Hey, it should be fixed now:

Note Hacker News logo is reporting detecting was done, but it is not possible to detect palette for ico format. We're working to add this support as well 🙂

spiffytech commented 2 years ago

Looks good!

My app must have been falling back to HN's site colors, and that color detection is working again, too.

Thanks!

Kikobeats commented 2 years ago

Hello again @spiffytech

I'm super happy to share you can now detect colors for ICO/BMP images as well.

e.g., https://api.microlink.io/?url=https%3A%2F%2Fmicrolink.io%2Ffavicon.ico&palette.

In fact, in case you are interested, all the following formats are supported now:

avif
bmp
cur
dds
eps
gif
heic
heif
ico
jpg
mng
odd
png
ps
psd
raw
svg
tga
tiff
webp

This is a non exhaustive list, but enough big to be compatible with almost any image 🙂

spiffytech commented 2 years ago

Excellent, I'm glad to see that roll out! Color palette support was an important reason I picked Microlink.

Kikobeats commented 2 years ago

That's super great!

Please, feel free to ping me again if you find any trouble, I want to be confident this work as good as possible 🙂