microlinkhq / unavatar

Get unified user avatar from social networks, including Instagram, SoundCloud, Telegram, Twitter, YouTube & more.
https://unavatar.io
MIT License
1.21k stars 70 forks source link

All providers return the default avatar #218

Closed sergioalvz closed 1 year ago

sergioalvz commented 1 year ago

Hey @Kikobeats 👋

I noticed that unavatar.io stopped working a couple of days ago (see https://unavatar.io/jack for example).

Running the service locally, I see the latest commit can't resolve most providers (they always return the default avatar). This is the commit where I see things start failing: b70fa083340182e3db2dd3328e34452601dee825.

I tried debugging the problem but couldn't find the root cause yet.

Let me know if there is something I can do to help!

Kikobeats commented 1 year ago

oh, really sorry for that, I found the bug 🤦 https://github.com/microlinkhq/unavatar/commit/af958b1915f31385e3d1a0a318d727b4a82280e1

Can you verify it's working fine for you now?

sergioalvz commented 1 year ago

Providers seem to be working now, but I think there is still a problem with the fallback option (always returning the default avatar instead).

I'm getting some intermittent failures for some avatars (sometimes getting the right image, sometimes getting the default avatar), but this might be related to my caching rather than with unavatar (saying it just in case).

Kikobeats commented 1 year ago

@sergioalvz sorry for that; I removed express as dependency the last week and I broke some code because of that.

I've started adding some tests to ensure everything goes back to normal https://github.com/microlinkhq/unavatar/pull/220

This branch is currently deployed to production, so you should to start to see avatars resolved properly.

sergioalvz commented 1 year ago

Thank you! Things look fairly back to normal. I'm always requesting avatars with a fallback to boringavatars.com and still getting the default unavatar's avatar sometimes, but it's looking good 🙌

Kikobeats commented 1 year ago

@sergioalvz I'm working in some improvements today to finally address all the issues 🙂