search

microlinkhq / youtube-dl-exec

A simple Node.js wrapper for youtube-dl/yt-dlp.
MIT License
423 stars 75 forks source link

feat: better types definition #174

Closed Kikobeats closed 10 months ago

Kikobeats commented 10 months ago

Closes #166

Gurimarukin commented 10 months ago

This used to work in my TypeScript: 

import { create } from 'youtube-dl-exec'

I now get a Module '"youtube-dl-exec"' has no exported member 'create'. error.

But create still exists on the js side.

I assume this got remove in the current PR.
Could you please restore it?

Kikobeats commented 10 months ago

@Gurimarukin Thanks for notifying, addressed at https://github.com/microlinkhq/youtube-dl-exec/pull/177

andremacola commented 5 months ago

This PR broke the typing mainly in systems that use previous versions. It removed, for example, filename, _filename and url which do indeed come in the return from youtubedl.