search

microlinkhq / youtube-dl-exec

A simple Node.js wrapper for youtube-dl/yt-dlp.
MIT License
423 stars 75 forks source link

post-install failures are minimized #190

Closed miraclx closed 6 months ago

miraclx commented 6 months ago

https://github.com/microlinkhq/youtube-dl-exec/blob/6db69be1a210272f161a7bade960133d5abe3d33/scripts/postinstall.js#L45-L47

Any errors at post-install are just logged, and this failure doesn't carry on to the calling process.

So neither npm or yarn are aware of this failure. You have to read the logs to find this out which is not ideal, and unreliable (especially in CI).

miraclx commented 6 months ago

Fixed in #192