micromark / micromark-extension-directive

micromark extension to support generic directives (`:cite[smith04]`)
https://unifiedjs.com
MIT License
31 stars 16 forks source link

fix extra colon mark in test #14

Closed Ahacad closed 3 years ago

Ahacad commented 3 years ago

Initial checklist

Description of changes

Removed one extra colon sign in test. I guess this is not a feature but a typo, if otherwise feel free to close it.

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (dc9d2fd) into main (5c561e0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1310      1310           
=========================================
  Hits          1310      1310           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c561e0...dc9d2fd. Read the comment docs.

wooorm commented 3 years ago

I think it's intended in this case 🤔. Directives can contain more directives if they have more colons. In this case that's also true because there are no closing fences

wooorm commented 3 years ago

Yeah, appreciate the effort on this, but I think it’s better the way it currently is: explicitly nested!

github-actions[bot] commented 3 years ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.