Closed instopunk closed 1 year ago
Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.
You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done!
Thanks, — bb
Welcome @instopunk! 👋 Could you add some context and description around what your are trying to solve here? Is this PR related to https://github.com/micromark/micromark-extension-directive/issues/8? Or something else entirely?
@ChristianMurphy Hello! I apologize for such a bad PR. I'm new to github and I'm just trying to figure out how everything is set up here =) Yes, these changes are related to the issue #8 you mentioned. I think I managed to solve it and it works for me. But I still don't know how to properly cover these changes with tests(
But I still don't know how to properly cover these changes with tests
To test it add examples in https://github.com/micromark/micromark-extension-directive/blob/main/test/index.js which rely on the new behavior you added.
Also based off https://github.com/micromark/micromark-extension-directive/issues/8#issuecomment-789809866 It sounds like the intent of that discussion may have been do have this behavior behind a flag? @wooorm would be able to confirm.
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/*
labels.
@instopunk if you're still interested this would be a good change to have. If you have follow up questions on testing or how to put a feature behind an option/flag feel free to ask.
@ChristianMurphy, oh thanks! I just need a little time to figure it out
Initial checklist
Description of changes
TODO