micromark / micromark-extension-directive

micromark extension to support generic directives (`:cite[smith04]`)
https://unifiedjs.com
MIT License
29 stars 16 forks source link

Container directive does not properly contain all contents when attributes are specified. #4

Closed Corvimae closed 3 years ago

Corvimae commented 3 years ago

Subject of the issue

I have a container directive that takes an optional argument theme. When I put a list inside the container, it is rendered within the container if there are no attribute braces and outside the container if there are braces and the closing ::: is rendered as text.

Your environment

Steps to reproduce

Without attribute braces:

:::card
**Test Content**

- This
- Is
- A
- List
:::
image

With attribute braces:

:::card{}
**Test Content**

- This
- Is
- A
- List
:::
image

Expected behavior

Both cards should render the same children.

Actual behavior

The card with attributes does not contain the list, and the closing ::: is rendered as text.

wooorm commented 3 years ago

Thanks, released! https://github.com/micromark/micromark-extension-directive/releases/tag/1.1.2