search

micromata / Baumeister

Unmaintained – :construction_worker: The aim of this project is to help you to build your things. From Bootstrap themes over static websites to single page applications.
MIT License
171 stars 37 forks source link

Generate `banner` in dist files #182

Closed nicolaisueper closed 7 years ago

nicolaisueper commented 7 years ago

We put a banner on top of every source file in earlier versions of Bootstrap Kickstart:

/*! <%= pkg.title %> - v<%= pkg.version %>\n +
 * <%= pkg.author.email %>\n +
 * Copyright ©<%= grunt.template.today("yyyy") %> <%= pkg.author.name %>\n +
 * <%= grunt.template.today("yyyy-mm-dd") %>\n +
 */

Do we still need this option? For our use cases it isn't needed usually. Can I get an upvote (👍) or downvote (👎) for reimplementing this feature into our new Gulp workflow @micromata/ux?

mischah commented 7 years ago

We don’t need that cause we disabled banners in production because of »security« reasons. See #27

If we decide to bring em back it should be a »global« setting in gulp/config.js like useBanners.

lfuelling commented 7 years ago

+1 for the optional way

mischah commented 7 years ago

Reopen because there is one who wants it.

@nicolaisueper takes care of implementing it.

Like said before: This is optional and defaults to useBanners = false.

mischah commented 7 years ago

Hej @nicolaisueper, what’s the status of this? 😘

I’d like to prepare the release of Baumeister v1.0.0 Should we ship this feature with Baumeister 1.1.0?

nicolaisueper commented 7 years ago

Hey @mischah, sorry for the late answer. I was quite busy the last days. I stopped working on it after I tried to gulp.src and gulp.dest multiple source directories. I found a way for gulp 3, but that does not work anymore. Going to research later. I also need to fix your requested changes in the v4 PR of the generator. :)

Maybe I get this done today/tomorrow. Otherwise we should ship it with a later version.

mischah commented 7 years ago

Done in v4 Branch. Will make it into Baumeister v1.0.0