search

micromata / Baumeister

Unmaintained – :construction_worker: The aim of this project is to help you to build your things. From Bootstrap themes over static websites to single page applications.
MIT License
171 stars 37 forks source link

feat(transpiling): Transform `async/await` using regenerator #207

Closed nicolaisueper closed 6 years ago

nicolaisueper commented 6 years ago

Heyho,

I solved the async/await issue using babel transform-runtime/transform-regenerator. This seems to be the only solution which doesn't require the whole babel-polyfill to be loaded.

Let me know if you've got any questions or requests for changes.

Greets Nico

mischah commented 6 years ago

The good thing: It won’t affect the bundle size If you don’t use async / await. The not so good thing: It will blow up the bundle size about 20k if you use async / await.

Guess thats kinda fair 🤷‍♂️

mischah commented 6 years ago

I’ll leave that open for another few days in case some of the others want to review this as well.

mischah commented 6 years ago

@micromata/ux

Last call to review.

Going to merge this tomorrow if there will be no other reviews until then.

mischah commented 6 years ago

Thank you very much @nicolaisueper 💯