micromata / Baumeister

Unmaintained – :construction_worker: The aim of this project is to help you to build your things. From Bootstrap themes over static websites to single page applications.
MIT License
171 stars 37 forks source link

Rename existing properties in baumeister.json #230

Closed mischah closed 6 years ago

mischah commented 6 years ago

I wonder if it makes sense to introduce two additional breaking changes with Baumeister v3.

It’s about the the following two properties in baumeister.json:

I would like to rename these to make the purpose easier to grasp.

Before

{
  "useHandlebars": true,
  "usePurifyCSS": true,
  "generateBanners": false,
  "bundleCSS": [],
  "includeStaticFiles": []
}

After

{
  "useHandlebars": true,
  "usePurifyCSS": true,
  "generateBanners": false,
  "vendor": {
    "bundleCSS": [],
    "includeStaticFiles": [],
  }
}

Can I get a πŸ‘ / πŸ‘Ž for the renaming?

mischah commented 6 years ago

Done in v3 branch.