search

micromata / dave

A totally simple and very easy to configure stand alone webdav server
Apache License 2.0
350 stars 46 forks source link

Docker Hub #24

Closed dmotte closed 3 years ago

dmotte commented 3 years ago

Hi! First of all, thanks for this software! :smiley:

It would be great to have the image in the Docker Hub, so one can do a docker pull without building it manually every time. Thanks in advance for your attention

idashevskii commented 3 years ago

I join the offer

chclaus commented 3 years ago

Good Idea. I will take care of it.

dmotte commented 3 years ago

@chclaus if you need inspiration on how to build it automatically for different architectures (amd64, arm, etc.), see this link from one of my recent projects https://github.com/dmotte/docker-portmap-client/tree/main/.github/workflows

There are two GitHub Actions workflows and in my opinion it is very simple to set up. You just have to copy the two .yml files, adapt them by changing the values (e.g. the image name) and set the DOCKERHUB_PASSWORD secret in the GitHub repo settings.

chclaus commented 3 years ago

Nice. Didn't worked with github actions until now.

Thanks. Stuff for tomorrow 😉

chclaus commented 3 years ago

Done. Results are here: https://hub.docker.com/repository/docker/micromata/dave/general

We currently have the issue, that the descriptions API of docker hub won't allow access tokens. https://github.com/peter-evans/dockerhub-description/issues/10

But i think the main part is solved ;)

dmotte commented 3 years ago

@chclaus Thanks for your work! This is extremely useful! I suggest adding a link to the Docker Hub page in the README file, maybe in the Build and run with Docker section :wink: Something like this:

This image is also on **Docker Hub** as [`micromata/dave`](https://hub.docker.com/r/micromata/dave).

Result:

This image is also on Docker Hub as micromata/dave.

chclaus commented 3 years ago

Yeah.... missed this yesterday @dmotte. Thanks for the reminder. ;)