search

micromatch / nanomatch

Fast, minimal glob matcher for node.js. Similar to micromatch, minimatch and multimatch, but without support for extended globs (extglobs), posix brackets or braces, and with complete Bash 4.3 wildcard support: ("*", "**", and "?").
https://github.com/micromatch
MIT License
96 stars 20 forks source link

Drop support for node 0.10, 0.12 and maybe more? #10

Closed danez closed 1 year ago

danez commented 6 years ago

@jonschlinkert What is your opinion on supported node versions in nanomatch, micromatch and dependencies?

I was wondering because we would do a major version anyway for the snapdragon updates, so we could at least drop node <=0.12, we could already even drop node 4 because it's eol is coming in less than a month. What do you think?

wtgtybhertgeghgtwtg commented 6 years ago

Would you use native stuff in place of packages where applicable, then? Like, Object.assign over extend-shallow, Map over map-cache?

jonschlinkert commented 6 years ago

I was wondering because we would do a major version anyway for the snapdragon updates

Definitely. Let's drop 4 after EOL though.

Would you use native stuff in place of packages where applicable, then? Like, Object.assign over extend-shallow, Map over map-cache?

Absolutely!

phated commented 6 years ago

@jonschlinkert if I were updating a 0.10 or 0.12 service, it'd be to node 4 so maybe keep that around longer than EOL? Remember that product owners can't move as fast as node core expects them to.

jonschlinkert commented 6 years ago

if I were updating a 0.10 or 0.12 service, it'd be to node 4 so maybe keep that around longer than EOL?

I'm totally fine with that. I love using the es6 features and reducing deps wherever possible, but there is no compelling argument not to be conservative.

wtgtybhertgeghgtwtg commented 6 years ago

Will a version with https://github.com/micromatch/nanomatch/pull/9 be released before this? It'd be nice if https://github.com/micromatch/micromatch/issues/122 could get done without requiring a major version bump for micromatch.

jonschlinkert commented 6 years ago

Will a version with #9 be released before this? It'd be nice if micromatch/micromatch#122 could get done without requiring a major version bump for micromatch.

I agree, but only if there are non-breaking changes.

danez commented 6 years ago

@wtgtybhertgeghgtwtg micromatch/micromatch#122 is a breaking change I think, as snapdragon was also updated to a new breaking version. The core apia should not break (match, createRegex, parse, etc), but also compilers and parsers are exposed and this definitely will not seamlessly work as they will require the latest snapdragon version. It is also just a number :)

jimmywarting commented 6 years ago

+1 for dropping support for eol version and only targeting LTS version (meaning v6+)