search

micromatch / nanomatch

Fast, minimal glob matcher for node.js. Similar to micromatch, minimatch and multimatch, but without support for extended globs (extglobs), posix brackets or braces, and with complete Bash 4.3 wildcard support: ("*", "**", and "?").
https://github.com/micromatch
MIT License
96 stars 20 forks source link

Remove isodd #11

Closed tonetheman closed 6 years ago

tonetheman commented 6 years ago

I removed is-odd from your dependencies. It looked like you used an npm package called is-odd.

It felt like you might not need a package to do that small of a test. No worries if you choose not to take the PR.

After my change I checked that all tests still passed. I did not add any new tests since the change looked like it would be tested during the negate portion of your existing tests.

kevinji commented 6 years ago

This looks identical to the patch in #7.

doowb commented 6 years ago

@tonetheman thanks for the PR!

/cc @jonschlinkert @phated @es128 if there are no objects, I think this can be published as a patch bump.

jonschlinkert commented 6 years ago

ftr, this is the last PR that will be accepted for is-odd or is-even. we don't have time for trolls.