micromatch / nanomatch

Fast, minimal glob matcher for node.js. Similar to micromatch, minimatch and multimatch, but without support for extended globs (extglobs), posix brackets or braces, and with complete Bash 4.3 wildcard support: ("*", "**", and "?").
https://github.com/micromatch
MIT License
95 stars 20 forks source link

regex-not 1.0.1 is broken #8

Closed stanleyxu2005 closed 6 years ago

stanleyxu2005 commented 6 years ago

https://github.com/micromatch/nanomatch/blob/15fa58f36a516aa2dd5ea70bef5dec2bc3ff7c81/package.json#L37

As regex-not new version 1.0.1 is broken, my application is failed to deploy on a fresh environment today. Do you think about cherry-pick policy to choose version "1.0.0" of this lib is better than having "^1.0.0"?

groie commented 6 years ago

We have a similar issue since today. With package-lock.json things work fine, but when we update the nanomatch to 1.2.9 (from 1.2.7) our world stops working with a regex-not problem.

jonschlinkert commented 6 years ago

This was resolved last night https://github.com/jonschlinkert/regex-not/issues/3#issuecomment-366850811

groie commented 6 years ago

in case someone reads this: 1.0.1 and 1.0.2 of regex-not were released very close to eachother. For some reason our internal npm-repository (nexus) had cached 1.0.1 and decided not to look for 1.0.2 in npmjs-repository. Thus all our builds were resolving to 1.0.1.

Solution was to invalidate the cache of our nexus-npmjs repository and thus everybody became a tad happier.

stanleyxu2005 commented 6 years ago

@groie Here is what I have done: regex-not is not a direct dependency, so I define "regex-not": "1.0.0" in package.json, so that npm will resolve the dependencies and decide to use 1.0.0.

jonschlinkert commented 6 years ago

Solution was to invalidate the cache of our nexus-npmjs repository and thus everybody became a tad happier.

The solution in https://github.com/micromatch/nanomatch/issues/8#issuecomment-366962549 is what should be done.