micromdm / scep

Go SCEP server
MIT License
323 stars 124 forks source link

Set digest algorithm to SHA256 to fix the insecure algorithm SHA1-RSA error. #191

Closed shuningzhou closed 10 months ago

shuningzhou commented 2 years ago

Getting the following error after upgrading to go 1.18: PKIOperation for PKCSReq (19): http request failed with status 500 Internal Server Error, msg: x509: cannot verify signature: insecure algorithm SHA1-RSA (temporarily override with GODEBUG=x509sha1=1)

Fixed the issue by setting the digest algorithm to SHA256.

jessepeterson commented 10 months ago

I don't think we can safely merge this as is. The SHA1/SHA2 stuff was "fixed" in Go 1.18.2, I believe. I'm open to talking more about it, though.