search

micromdm / scep

Go SCEP server
MIT License
310 stars 121 forks source link

Add DNSName flag to scepclient #202

Closed macmule closed 1 year ago

macmule commented 1 year ago

Whilst DNSNames have been referenced in the cert template (https://github.com/micromdm/scep/blob/main/depot/signer.go#L81-L97), neither the scepclient did not have the option to add these to the CSR.

This PR resolves that by adding the option via a dnsname flag.

This could be improved upon though by adding multiple, but a little beyond my 1 days worth of Go experience.

macmule commented 1 year ago

Sorry, made another commit which caught the changes after the mixedCaps miss

macmule commented 1 year ago

ran via gofmt -s each file flagged with gofmt -s -l a few times.. and gofmt -w.. now gofmt -s -l has no output.. so fingers crossed this has worked.