search

micrometer-metrics / micrometer

An application observability facade for the most popular observability tools. Think SLF4J, but for observability.
https://micrometer.io
Apache License 2.0
4.47k stars 990 forks source link

Run tests on OpenJ9 #1462

Closed shakuzen closed 10 months ago

shakuzen commented 5 years ago

In addition to HotSpot, we try to support OpenJ9 where applicable and feasible. We, however, don't run our test suite on an OpenJ9 JVM to proactively catch issues and ensure compatibility. We should consider adding an OpenJ9 build.

marcingrzejszczak commented 10 months ago

Is this still something we want to do @shakuzen ?

github-actions[bot] commented 10 months ago

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

github-actions[bot] commented 10 months ago

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open.

shakuzen commented 10 months ago

We claim to support JVM metrics on OpenJ9, so yes, it would generally be good that we actually run tests on OpenJ9. I think it will require creating a custom container image to run tests on or otherwise use different images than the convenience images offered by CircleCI since they rejected the request to add OpenJ9 variants: https://github.com/CircleCI-Public/cimg-openjdk/issues/78