search

micrometer-metrics / micrometer

An application observability facade for the most popular observability tools. Think SLF4J, but for observability.
https://micrometer.io
Apache License 2.0
4.45k stars 980 forks source link

ExecutorServiceMetrics should add the type of executor as a tag #1680

Open fkoehler opened 4 years ago

fkoehler commented 4 years ago

In https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java#L180-L236 the generated metrics do not contain the type of executor which is being measured. I.e.: threadpool or forkjoinpool. It is unclear what kind of executor is being used.

I'd suggest adding a tag type or executor_type where we either set threadpool or forkjoinpool. I can provide a PR for that.

shakuzen commented 3 years ago

The only overlap I'm seeing in meter names is executor.active and executor.queued. Are these the metrics you're wanting to distinguish the type of executor on?