search

micrometer-metrics / micrometer

An application observability facade for the most popular observability tools. Think SLF4J, but for observability.
https://micrometer.io
Apache License 2.0
4.47k stars 990 forks source link

Add Observed Tomcat Valve #3777

Open marcingrzejszczak opened 1 year ago

marcingrzejszczak commented 1 year ago

Example here https://github.com/micrometer-metrics/micrometer-samples/blob/4f9a6cd9d1c12fa19ec79a49766cce6afccd5ce2/micrometer-samples-boot3-web/src/main/java/io/micrometer/boot3/samples/web/ManualConfiguration.java#L41-L96

fischermatte commented 8 months ago

@marcingrzejszczak Do you have a solution to this?

jonatan-ivanov commented 8 months ago

What are you seeking a solution for? Have you checked the code in the description of this PR?

fischermatte commented 8 months ago

Sry, maybe I misunderstood something. I am coming from this issue (Exceptions are not logged with span-id/trace-id with latest spring boot). There @bclozel mentioned this

"You can follow https://github.com/micrometer-metrics/micrometer/issues/3777 if you'd like to instrument your application at a lower level with Tomcat."

Now it looks like this PR is still open for some reason. Do you see any chance that exceptions logged from tomcat itself can be enhanced with a trace-id/span-id?

marcingrzejszczak commented 6 months ago

Tomcat valve instrumentation is done here - https://github.com/micrometer-metrics/micrometer/pull/3989/