search

micrometer-metrics / micrometer

An application observability facade for the most popular observability tools. Think SLF4J, but for observability.
https://micrometer.io
Apache License 2.0
4.48k stars 992 forks source link

Metrics for Spring WebFlux WebClient #772

Closed PyvesB closed 6 years ago

PyvesB commented 6 years ago

Hello there,

According to the documentation, Micrometer supports http.client.requests for "any RestTemplate created using the auto-configured RestTemplateBuilder".

Nevertheless, even though there is support for http.sever.requests metrics handled by WebFlux controllers and functional handlers, there doesn't seem to be any equivalent client metrics for WebClient, which is a reactive version of RestTemplate.

Am I missing something here? Are there any plans to add such support?

Thanks in advance!

Kind regards,

Pyves

shakuzen commented 6 years ago

Support for WebClient metrics have been added in Spring Boot. See https://github.com/spring-projects/spring-boot/issues/12228. Support would not go here because the micrometer-spring-legacy is for Spring Boot 1.5.x, which uses Spring 4.x, before WebClient was introduced in Spring 5.