search

micrometer-metrics / tracing

Provides tracing abstractions over tracers and tracing system reporters.
https://micrometer.io
Apache License 2.0
244 stars 43 forks source link

Move to io.opentelemetry.semconv:opentelemetry-semconv #343

Closed shakuzen closed 1 year ago

shakuzen commented 1 year ago

io.opentelemetry:opentelemetry-semconv was moved to io.opentelemetry.semconv:opentelemetry-semconv and the former will be deprecated.

Edit: That will only impact 1.2.x though, not 1.1.x what this issue should be for. Edit2: Moving to the new semconv artifact will be the problem of the next release (1.2.0-RC1) .

Originally posted by @jonatan-ivanov in https://github.com/micrometer-metrics/tracing/issues/340#issuecomment-1710656093

marcingrzejszczak commented 1 year ago

The way I did it is actually a breaking change cause we don't include the deprecated dependency anymore. @wilkinsona is this actually ok from point of view e.g. Boot or should we add both dependencies and remove the deprecated one in e.g. 1-2 minors?

wilkinsona commented 1 year ago

I'll have a better feel for it once we've moved to snapshots next week, but I think that's probably OK. My expectation is that anyone who really needs the deprecated one can add the dependency directly. We consider that kind of easily fixed problem to be fine for a new minor release of Boot.