Code Lab Feedback - Githubissues

micronaldkelly / codelab-css-intro

https://github.com

0 stars 0 forks source link

Code Lab Feedback #1

Open micronaldkelly opened 8 years ago

micronaldkelly commented 8 years ago

Hey @kieraw, can you take a look at this? It's hosted here and meets the following project criteria:

[x] include at least one instance of each of the following properties: margin, padding, border, color, background, font-size, line-height (properties must have a visible effect)
[x] return no errors (warnings are OK) when the HTML document is uploaded to the W3C Markup Validation Service
[x] return no errors or warnings when contents of your CSS are pasted into CSS Lint

ghost commented 8 years ago

@micronaldkelly no W3C Markup errors which is great! However can't find your CSS code in the codelab-css-intro repository (I need it to do the CSS Lint check). Might just have forgotten to push! Let me know when you do! Thanks! :) --Kiera

micronaldkelly commented 8 years ago

lowly-cabbage.surge.sh

Let me know if this is okay so that I can solve the other issues at hand! :)

ghost commented 8 years ago

@micronaldkelly this is returning W3C Markup errors now, still can't check for CSS warnings because the code isn't pushed yet. Let me know when you fix this! :) --Kiera

micronaldkelly commented 8 years ago

gruesome-angle.surge.sh

I hope this helps!

ghost commented 8 years ago

@micronaldkelly This is still returning errors, and your code isn't pushed to your repo still. Let me know when you got it :) --Kiera

micronaldkelly commented 8 years ago

prickly-oil.surge.sh

I swear I did it this time

ghost commented 8 years ago

@micronaldkelly You're all good!!!! :shipit: --Kiera :)