TCK: constraint handler improve

micronaut-projects / micronaut-core

Micronaut Application Framework

http://micronaut.io

Apache License 2.0

6.05k stars 1.06k forks source link

TCK: constraint handler improve #10909

Closed andriy-dmytruk closed 3 months ago

andriy-dmytruk commented 3 months ago

This would solve this issue: https://github.com/micronaut-projects/micronaut-oracle-cloud/issues/925 that the oracle cloud HTTP functions are facing with server TCK.

graemerocher commented 3 months ago

probably this is small enough to target 4.5.x

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yawkat commented 3 months ago

I don't think this change is correct. I believe we have code that relies on the controller body type being set in the request in case of validation error.

@sdelamo do you know more? since you wrote this tck test.

sdelamo commented 3 months ago

yes, the test was verifying that you could access the method annotated with @Error the request body with the same type used in the @Post methods.

yawkat commented 3 months ago

Then we need to revert this