highmtworks
commented
3 years ago As the nested calls of computeIfAbsent are invoked on the same thread (as the stack trace shows),
I suspect that adding synchronized ( without removing computedIfAbsent ) will have no effect for this issue.
I am sorry to be late, but I created a possible reproducer. Could you try this one please ?
-
mn create-app test5469 -
add the following
Test5469Controller.javafile in test5469/src/main/java/test5469
package test5469;
import javax.inject.Inject;
import io.micronaut.context.ApplicationContext;
import io.micronaut.context.annotation.Factory;
import io.micronaut.http.MediaType;
import io.micronaut.http.annotation.Controller;
import io.micronaut.http.annotation.Get;
import io.micronaut.runtime.http.scope.RequestScope;
@Controller("/test5469")
public class Test5469Controller {
@Inject
private ApplicationContext applicationContext;
@Get(produces = MediaType.TEXT_PLAIN)
public String index() {
var c = applicationContext.getBean(Component1.class);
c.touch();
return "OK";
}
}
@Factory class Component1Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component1 getComponent() { var c = applicationContext.getBean(Component2.class); c.touch(); return new Component1(); } }
@Factory class Component2Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component2 getComponent() { var c = applicationContext.getBean(Component3.class); c.touch(); return new Component2(); } }
@Factory class Component3Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component3 getComponent() { var c = applicationContext.getBean(Component4.class); c.touch(); return new Component3(); } }
@Factory class Component4Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component4 getComponent() { var c = applicationContext.getBean(Component5.class); c.touch(); return new Component4(); } }
@Factory class Component5Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component5 getComponent() { var c = applicationContext.getBean(Component6.class); c.touch(); return new Component5(); } }
@Factory class Component6Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component6 getComponent() { var c = applicationContext.getBean(Component7.class); c.touch(); return new Component6(); } }
@Factory class Component7Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component7 getComponent() { var c = applicationContext.getBean(Component8.class); c.touch(); return new Component7(); } }
@Factory class Component8Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component8 getComponent() { var c = applicationContext.getBean(Component9.class); c.touch(); return new Component8(); } }
@Factory class Component9Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component9 getComponent() { var c = applicationContext.getBean(Component10.class); c.touch(); return new Component9(); } }
@Factory class Component10Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component10 getComponent() { var c = applicationContext.getBean(Component11.class); c.touch(); return new Component10(); } }
@Factory class Component11Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component11 getComponent() { var c = applicationContext.getBean(Component12.class); c.touch(); return new Component11(); } }
@Factory class Component12Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component12 getComponent() { var c = applicationContext.getBean(Component13.class); c.touch(); return new Component12(); } }
@Factory class Component13Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component13 getComponent() { var c = applicationContext.getBean(Component14.class); c.touch(); return new Component13(); } }
@Factory class Component14Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component14 getComponent() { var c = applicationContext.getBean(Component15.class); c.touch(); return new Component14(); } }
@Factory class Component15Factory { @Inject private ApplicationContext applicationContext; @RequestScope public Component15 getComponent() { var c = applicationContext.getBean(Component16.class); c.touch(); return new Component15(); } }
@Factory class Component16Factory { @RequestScope public Component16 getComponent() { return new Component16(); } }
class Component1 { public void touch() { } }
class Component2 { public void touch() { } }
class Component3 { public void touch() { } }
class Component4 { public void touch() { } }
class Component5 { public void touch() { } }
class Component6 { public void touch() { } }
class Component7 { public void touch() { } }
class Component8 { public void touch() { } }
class Component9 { public void touch() { } }
class Component10 { public void touch() { } }
class Component11 { public void touch() { } }
class Component12 { public void touch() { } }
class Component13 { public void touch() { } }
class Component14 { public void touch() { } }
class Component15 { public void touch() { } }
class Component16 { public void touch() { } }-
gradlew run -
then access
curl http://localhost:8080/test5469
It will return
{"message":"Internal Server Error: Error instantiating bean of type [test5469.Component1]: Recursive update","_links":{"self":{"href":"/test5469","templated":false}}}on micronaut 2.5.9.
mancze
glazzari
johndevs
Rare occurrence of "Recursive update"
After #5384, it can fail to instantiate beans of RequestScope depending on other RequestScope beans. It does not occur deteministically, but if it occurs, it continues to occur.
I am very sorry not to attach code to reproduce, because this occurred in production and as the product is not open, I cannot share it, and I have little time to write new reproduction code.
Instead, I describe what I investigated. If I get time, I may add reproduction code.
Task List
Steps to Reproduce
@RequestScope, instantiated by@Factory@Factoryuses another bean of@RequestScopeto instatiate the bean aboveExpected Behaviour
Instantiation of beans of RequestScope depending on other RequestScope beans succeeds.
Actual Behaviour
BeanInstantiationException with the inner exception 'java.lang.IllegalStateException: Recursive update' is thrown.
Stack trace from the inner exception (some code masked):
What I investigated:
where ConcurrentHashMap is the attribute 'io.micronaut.http.SCOPED_BEANS' of HTTP requests that stores instantiated RequestScope beans.
Environment Information
Example Application