dstepanov
commented
11 months ago I don't think anything can be fixed here, the main problem is that you are using Mono.from which is canceling the upstream and that is causing all kind of problems. The solution is to use Mono.fromDirect or use Reactor alternatives of connection/transaction managers.
I did rewrite your code to:
private final R2dbcOperations r2dbcOperations;
private final ReactorConnectionOperations<Connection> connectionOperations;
private final ReactorReactiveTransactionOperations<Connection> transactionOperations;
@Override
public Flux<Customer> findAll() {
var sql = "SELECT * FROM customers ";
return connectionOperations.withConnectionFlux(status -> Flux
.from(status.getConnection().createStatement(sql).execute())
.flatMap(r -> r.map(MAPPING_FUNCTION))
);
}
@Override
public Mono<Customer> findById(UUID id) {
var sql = "SELECT * FROM customers WHERE id=$1 ";
return connectionOperations.withConnectionMono(status -> Mono
.from(status.getConnection().createStatement(sql)
.bind(0, id)
.execute()
)
.flatMap(r -> Mono.from(r.map(MAPPING_FUNCTION)))
.switchIfEmpty(Mono.empty())
);
}
@Override
public Mono<UUID> save(Customer data) {
//var sql = "INSERT INTO customers(name, age, street, city, zip) VALUES (?, ?, ?, ?, ?) RETURNING id ";
var sql = "INSERT INTO customers (name, age, street, city, zip) VALUES ($1, $2, $3, $4, $5)";
return transactionOperations.withTransactionMono(status ->
Mono.just(status.getConnection())
.flatMap(connection -> Mono
.from(connection.createStatement(sql)
.bind(0, data.name())
.bind(1, data.age())
.bind(2, data.address().street())
.bind(3, data.address().street())
.bind(4, data.address().zip())
.returnGeneratedValues("id")
.execute()
)
.flatMap(r -> Mono.from(r.map((row, rowMetadata) -> row.get("id", UUID.class))))
.switchIfEmpty(Mono.empty())
)
);
}Which makes the test pass even with some remaining Mono.from. I think we had some hack in v3 and it might have worked.
hantsy
Expected Behavior
I used
R2dbcOperations.withConnectionto build a Repository like this.The complete CustomerDaoWithR2dbcOperations is here.
And the CustomerDaoWithR2dbcOperationsTest failed now.
Actual Behaviour
Steps To Reproduce
Environment Information
Windows 10 pro Java 17
Example Application
https://github.com/hantsy/micronaut-sandbox/tree/master/data-r2dbc
Version
4.0.0