search

micronaut-projects / micronaut-discovery-client

Micronaut's Discovery Client
Apache License 2.0
22 stars 20 forks source link

Consul with serde #523

Closed sdelamo closed 1 year ago

sdelamo commented 1 year ago

Close: #517

This PR fixes the consul integration, which was not working with Micronaut Serialization.

This PR uses java records to map the consul API and remove the usage of abstract hierarchies for API POJOs.

it simplifies also ConsulAutoRegistration.java extracting several methods.

sdelamo commented 1 year ago

japiCmp tasks seems to be failing for me?

https://ge.micronaut.io/s/ku25ahja2y4vq

I have added entries to accepted-api-changes.json for the @Deprecated classes CheckEntry, HealthEntry, HTTPCheck, NewCheck, TTLCheck.

I am unsure why those entries must be added since the only modification to those classes is the addition of the `@Deprecated annotations.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

87.3% 87.3% Coverage
0.0% 0.0% Duplication