micronaut-projects / micronaut-gradle-plugin

A Gradle Plugin for Micronaut
Apache License 2.0
65 stars 43 forks source link

Micronaut-openapi 6.7.0 #950

Closed altro3 closed 3 months ago

altro3 commented 4 months ago

Added test to clientId generator property

Fixed #949

timyates commented 3 months ago

We've already merged 6.6.3 https://github.com/micronaut-projects/micronaut-gradle-plugin/pull/961

I want to make a patch release for 4.3.5 of the Gradle plugin as there's bug fixes in it

4.3.5 of the gradle plugin will then go out with 4.3.7 of Micronaut (next patch)

Ideally, we shouldn't wait for Micronaut 4.4.0 (next minor) to include the bugfixes

Unless you're saying I should revert the update to 6.6.3?

timyates commented 3 months ago

@altro3 this pr only makes a single change

https://github.com/micronaut-projects/micronaut-gradle-plugin/pull/950/files#diff-0d8feb3d2e60a4085c22391e83952def203f6d69a5ae209e04b1886d52a971f9

(plus 2 tests)

Should it be closed then?

Or should I revert the 6.6.3 update?

altro3 commented 3 months ago

I'll change this PR to 6.7.0. In 6.7.0 will be one more property. Need to add it here. I'll do it timorrow

timyates commented 3 months ago

@altro3 should I revert the 6.6.3 update for the next patch release of this plugin?

We (obviously) cannot release 6.7.0 (a minor update) in a patch plugin release

And I want the patch plugin for the next patch micronaut release

altro3 commented 3 months ago

It desn't matter. With 6.6.3 all works fine, but as I remeber I've added one more property for configuration. And all that is not completed is that you will not be able to set this property through the plugin.

timyates commented 3 months ago

Ok, I'll leave this PR in draft for now, but release 4.3.5 of the plugin with 6.6.3 of the openapi generator

sdelamo commented 3 months ago

Lets go ahead with the patch release of the gradle plugin and then we can make a minor release with the minor of open api

altro3 commented 3 months ago

@timyates @melix All ready to review and merge